On 19 September 2011 15:00, Oleg Kalnichevski <[email protected]> wrote: > On Mon, 2011-09-19 at 09:43 -0400, Bill Speirs wrote: >> I never like the idea of removing test cases... could we bump the timeouts >> up?
I tried adding a pause of 90 seconds at line 176 of TestDefaultIOReactors, but that did not help - the server connection count check always fails. >> >> I just updated to r1172624, and all tests pass for me. My system was >> completely unused except for these tests though. >> Which OS? I am using WinXP; system not heavily loaded. > > Socket / connect timeout values for test cases are currently set to 60 > seconds which looks adequate. Since I am unable to reproduce the problem > in the first place, I am not sure bumping timeout values would solve it. > At any rate, this can be done after the release and I am not sure this > issue should block the release at all. I think we need to know a bit more about the possible cause to be sure it's not a critical issue. I'll try and see if I can debug further here. > Oleg > >> Bill- >> >> On Mon, Sep 19, 2011 at 9:26 AM, Oleg Kalnichevski <[email protected]> wrote: >> >> > On Mon, 2011-09-19 at 13:57 +0100, sebb wrote: >> > > On 18 September 2011 16:25, Oleg Kalnichevski <[email protected]> wrote: >> > > > Please vote on releasing these packages as HttpComponents Core >> > > > 4.2-alpha2. The vote is open for the at least 72 hours, and only votes >> > > > from HttpComponents PMC members are binding. The vote passes if at >> > least >> > > > three binding +1 votes are cast and there are more +1 than -1 votes. >> > > > >> > > > Packages: >> > > > http://people.apache.org/~olegk/httpcore-4.2-alpha2-RC1/ >> > > >> > > I get the following test error: >> > > >> > > Failed tests: >> > > >> > testGracefulShutdown(org.apache.http.impl.nio.reactor.TestDefaultIOReactorsSSL): >> > > expected:<15> but was:<13> >> > > >> > >> > I am not able to reproduce the problem. All I can do is to remove the >> > offending test case, if you prefer it this way. >> > >> > Please note that NIO test cases may fail intermittently on a busy system >> > due to a timeout. >> > >> > Oleg >> > >> > > > Release notes: >> > > > >> > http://people.apache.org/~olegk/httpcore-4.2-alpha2-RC1/RELEASE_NOTES.txt >> > > > >> > > > Maven artefacts: >> > > > >> > https://repository.apache.org/content/repositories/orgapachehttpcomponents-074/org/apache/httpcomponents/ >> > > > >> > > > SVN tag: >> > > > >> > http://svn.apache.org/repos/asf/httpcomponents/httpcore/tags/4.2-alpha2-RC1/ >> > > >> > > I reviewed r1172570. >> > > >> > > Apart from the test error, everything looks OK. >> > > >> > > Abstaining for now. >> > > >> > > > >> > -------------------------------------------------------------------------- >> > > > Vote: HttpComponents Core 4.2-alpha2 release >> > > > [ ] +1 Release the packages as HttpComponents Core 4.2-alpha2. >> > > > [ ] -1 I am against releasing the packages (must include a reason). >> > > > >> > > > >> > > > --------------------------------------------------------------------- >> > > > To unsubscribe, e-mail: [email protected] >> > > > For additional commands, e-mail: [email protected] >> > > > >> > > > >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: [email protected] >> > > For additional commands, e-mail: [email protected] >> > > >> > >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
