[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472354#comment-13472354
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1238:
-----------------------------------------------

Dominique

Speaking from personal experience both contributing and reviewing / accepting 
large change sets it is often much easier and productive to feed things in as a 
series of smaller incremental patches instead of trying to cover everything 
with one mega patch. Consider splitting things up into more granular change 
sets and submit least complicated / intrusive first.  

> for this i request your ideas, if it is at all worth the effort. 
> non-system-properties and non-osgi configuration would most likely result in 
> a new dependency

Let's focus on system properties based / OSGi configuration first and see where 
it is going to take us.

Oleg 
                
> Contribute Bundle Activator And Central Proxy Configuration
> -----------------------------------------------------------
>
>                 Key: HTTPCLIENT-1238
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1238
>             Project: HttpComponents HttpClient
>          Issue Type: Wish
>          Components: HttpClient
>    Affects Versions: 4.2.1
>            Reporter: Dominique Jäggi
>            Priority: Minor
>             Fix For: 4.3 Final
>
>         Attachments: HTTPCLIENT-1238-2.patch, HTTPCLIENT-1238.patch
>
>
> as discussed at [0] i'd like to contribute the bundle activator and central 
> proxy configuration.
> the attached patch may need some cleanup on your side, as only assumed 
> locations where to put some classes or in which pom.xml to put dependencies.
> i kindly ask you to review the patch in if possible integrate it in a future 
> release.
> Adobe (and i as its employee) is available for assistance, explanations, or 
> further dev work required in the context of the patch.
> [0] 
> http://mail-archives.apache.org/mod_mbox/hc-dev/201209.mbox/%3cCACMijv-21S4+Jw_A=jdfhevb9cmt4kni5p3jahzfh3kvu4b...@mail.gmail.com%3e

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to