Justus Pendleton created HTTPCLIENT-1248:
--------------------------------------------
Summary: LaxRedirectStrategy converts POST to GET
Key: HTTPCLIENT-1248
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1248
Project: HttpComponents HttpClient
Issue Type: Bug
Reporter: Justus Pendleton
The LaxRedirectStrategy extends the DefaultRedirectStrategy. The
DefaultAsyncRequestDirector calls _redirectStrategy.isRedirected()_ and
LaxRedirectStrategy will return *true* on a POST. Then the director calls
_redirectStrategy.getRedirect()_. The LaxRedirectStrategy doesn't implement
this method so the one in the DefaultRedirectStrategy is called:
{code}
if (method.equalsIgnoreCase(HttpHead.METHOD_NAME)) {
return new HttpHead(uri);
} else {
return new HttpGet(uri);
}
{code}
This turns the POST into a GET on redirect. IMHO the LaxRedirectStrategy should
be
{code}
public HttpUriRequest getRedirect(
final HttpRequest request,
final HttpResponse response,
final HttpContext context) throws ProtocolException {
URI uri = getLocationURI(request, response, context);
String method = request.getRequestLine().getMethod();
if (method.equalsIgnoreCase(HttpHead.METHOD_NAME)) {
return new HttpHead(uri);
else if (method.equalsIgnoreCase(HttpPost.METHOD_NAME)) {
return new HttpPost(uri);
} else if (method.equalsIgnoreCase(HttpGet.METHOD_NAME)) {
return new HttpGet(uri);
} else {
throw new IllegalStateException("Redirect called on un-redirectable
http method: " + method);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
