On Jan 15, 2013, at 20:06, sebb <seb...@gmail.com> wrote: > On 15 January 2013 18:41, Gary Gregory <garydgreg...@gmail.com> wrote: >> On Tue, Jan 15, 2013 at 1:30 PM, sebb <seb...@gmail.com> wrote: >> >>> On 15 January 2013 18:25, Gary Gregory <garydgreg...@gmail.com> wrote: >>>> Can you build? >>> >>> Did it build before the changes? >>> >> >> Nope, not before this one :( > > In that case I don't understand what your question has to do with my change?
Personally, I would want to know that POM change does not break the build. So I assumed that the build worked for you and that you tested the POM change locally. G > >> Gary >> >> >>> >>>> From the project dir, "mvn clean test" gives me: >>>> >>>> [ERROR] Failed to execute goal >>>> org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle >>>> (validate) on project httpcomponents-core: An error has occurred in >>>> Checkstyle report generation. Failed during checkstyle configurat >>>> ion: cannot initialize module Header - unable to load header file >>>> asl2.header: asl2.header (The system cannot find the file specified) -> >>>> [Help 1] >>>> >>>> Gary >>>> >>>> >>>> On Tue, Jan 15, 2013 at 1:22 PM, <s...@apache.org> wrote: >>>> >>>>> Author: sebb >>>>> Date: Tue Jan 15 18:22:13 2013 >>>>> New Revision: 1433565 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=1433565&view=rev >>>>> Log: >>>>> Add Maven minimum version pre-requisite; update clirr and buildnumber >>>>> plugin versions >>>>> >>>>> Modified: >>>>> httpcomponents/project/trunk/pom.xml >>>>> >>>>> Modified: httpcomponents/project/trunk/pom.xml >>>>> URL: >>>>> >>> http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=1433565&r1=1433564&r2=1433565&view=diff >>>>> >>>>> >>> ============================================================================== >>>>> --- httpcomponents/project/trunk/pom.xml (original) >>>>> +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 18:22:13 2013 >>>>> @@ -44,6 +44,13 @@ >>>>> >>>>> >>>>> <!-- >>>>> +Version 7 - changes since version 6 >>>>> +=================================== >>>>> + >>>>> +Added Maven pre-requisite of 2.2.1 (minimum) >>>>> +Clirr 2.3 => 2.5 >>>>> +Buildnumber 1.0 => 1.2 >>>>> + >>>>> Changes since previous version (5) >>>>> ============================== >>>>> >>>>> @@ -526,7 +533,7 @@ Felix bundle plugin updated: 2.3.5 -> 2. >>>>> <plugin> >>>>> <groupId>org.codehaus.mojo</groupId> >>>>> <artifactId>buildnumber-maven-plugin</artifactId> >>>>> - <version>1.0</version> >>>>> + <version>1.2</version> >>>>> </plugin> >>>>> <plugin> >>>>> <groupId>org.codehaus.mojo</groupId> >>>>> @@ -675,6 +682,10 @@ Felix bundle plugin updated: 2.3.5 -> 2. >>>>> >>>>> </profiles> >>>>> >>>>> + <prerequisites> >>>>> + <maven>2.2.1</maven> >>>>> + </prerequisites> >>>>> + >>>>> <properties> >>>>> <maven.compile.source>1.5</maven.compile.source> >>>>> <maven.compile.target>1.5</maven.compile.target> >>>>> @@ -689,7 +700,7 @@ Felix bundle plugin updated: 2.3.5 -> 2. >>>>> <!-- TODO - try 3.1.0 --> >>>>> <clover.version>2.6.3</clover.version> >>>>> <!-- Define versions of all report plugins, because they should >>> match >>>>> usage in pluginManagement and modules --> >>>>> - <hc.clirr.version>2.3</hc.clirr.version> >>>>> + <hc.clirr.version>2.5</hc.clirr.version> >>>>> <hc.javadoc.version>2.8</hc.javadoc.version> >>>>> <hc.jxr.version>2.3</hc.jxr.version> >>>>> <hc.surefire-report.version>2.9</hc.surefire-report.version> >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 >>>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org >>> For additional commands, e-mail: dev-h...@hc.apache.org >>> >>> >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 >> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
