On 18 March 2014 08:47, Oleg Kalnichevski <[email protected]> wrote: > On Tue, 2014-03-18 at 01:04 +0000, sebb wrote: >> There are 83 instances of case conversion using a Locale (none >> without) in HC project trunk >> >> Of these, there are: >> >> 23 Locale.ENGLISH (includes 4 comments) >> 33 Locale.ROOT (Java 1.6+; httpasycclient currently uses 1.5) >> 27 Locale.US (httpclient/httpcore only) >> >> It does not make sense to me to use US (or UK). >> Although they are short, they are too specific. >> ROOT is ideal, but is 1.6+ >> >> httpasyncclient only has 5 instances of Locale, two of which are comments. >> It only uses ENGLISH. >> >> I propose to convert the Locale instances in client and core to ROOT. >> The httpasyncclient component can be done when it requires 1.6 >> >> OK? >> > > I think I have already changed all non-deprecated classes in core and > client to use Locale.ROOT. I see no point changing deprecated code.
Two of the Locale.US references are in the java-deprecated tree. The rest are not in that tree. Given that there are only 2 deprecated references, I think it would make sense to change them anyway. Make checking the source easier. > Oleg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
