[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Kalnichevski resolved HTTPCLIENT-1557.
-------------------------------------------
       Resolution: Fixed
    Fix Version/s: 4.4 Beta2

Karl,
I took the liberty of refactoring your code. Could you please review and let me 
know if everything is in order?

https://github.com/apache/httpclient/commit/b47a2333bf02c214928907b27582a256586684b7

Oleg

> NTLMEngine.Type1Message doesn't do anything with domain and host
> ----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1557
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1557
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.2.6
>            Reporter: Stéphane Landelle
>             Fix For: 4.4 Beta2
>
>
> Since 4.2.3, NTLMEngine.Type1Message doesn't actually do anything with domain 
> and host parameters. It computes bytes from them, but don't do anything with 
> those.
> Is this intended? I get that domain and host are optional, but should they 
> really be completely ignored?
> If so, Type1Message could be turned as a singleton, as the message ends up 
> being always the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to