Github user ok2c commented on the pull request:
https://github.com/apache/httpcore/pull/7#issuecomment-62690756
Hi Dmitry
I understand the rationale behind these changes but do they really result
in a tangible performance improvement? You see, generally IOSession should
mostly be interacted with by one IO dispatch thread and therefore there should
almost no thread contention to start with (besides IO interest operations).
I also would replace this bit in #close() method with
AtomicInteger#compareAndSet
```java
synchronized (this) {
if (this.status == CLOSED) {
return;
}
this.status = CLOSED;
}
```
Oleg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
