[
https://issues.apache.org/jira/browse/HTTPCLIENT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Feiner updated HTTPCLIENT-1761:
--------------------------------------
Description:
While the method
{code}
public static List<NameValuePair> parse(String s, Charset charset, char...
separators)
{code}
has a null check for String "s", this method has no null check:
```
public static List<NameValuePair> parse(String s, Charset charset)
```
For consistency and backward compatibility reasons I recommend adding a null
check there.
Furthermore I would delegate to the method with separators:
```
public static List<NameValuePair> parse(String s, Charset charset) {
return SafeURLEncodedUtils.parse(s, charset, '&', ';');
}
```
was:
While the method
```
public static List<NameValuePair> parse(String s, Charset charset, char...
separators)
```
has a null check for String "s", this method has not
```
public static List<NameValuePair> parse(String s, Charset charset)
```
For consistency and backward compatibility reasons I recommend adding a null
check there.
Furthermore I would delegate to the method with separators:
```
public static List<NameValuePair> parse(String s, Charset charset) {
return SafeURLEncodedUtils.parse(s, charset, '&', ';');
}
```
> Missing null check in parse method
> ----------------------------------
>
> Key: HTTPCLIENT-1761
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1761
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.4.1, 4.5, 4.5.1, 4.5.2
> Reporter: Thomas Feiner
>
> While the method
> {code}
> public static List<NameValuePair> parse(String s, Charset charset, char...
> separators)
> {code}
> has a null check for String "s", this method has no null check:
> ```
> public static List<NameValuePair> parse(String s, Charset charset)
> ```
> For consistency and backward compatibility reasons I recommend adding a null
> check there.
> Furthermore I would delegate to the method with separators:
> ```
> public static List<NameValuePair> parse(String s, Charset charset) {
> return SafeURLEncodedUtils.parse(s, charset, '&', ';');
> }
> ```
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
