[
https://issues.apache.org/jira/browse/HTTPCLIENT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415530#comment-15415530
]
Gary Gregory edited comment on HTTPCLIENT-1761 at 8/10/16 4:29 PM:
-------------------------------------------------------------------
Hello [~tfeiner]:
Please feel free to submit patches for branche(s) you care about and/or master.
Gary
was (Author: garydgregory):
Hello [~tfeiner]:
Please feel free to submit a patch for branche(s) you care about and/or master.
Gary
> Missing null check in parse method
> ----------------------------------
>
> Key: HTTPCLIENT-1761
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1761
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.4.1, 4.5, 4.5.1, 4.5.2
> Reporter: Thomas Feiner
>
> While in org.apache.http.client.utils.URLEncodedUtils the method
> {code}
> public static List<NameValuePair> parse(String s, Charset charset, char...
> separators)
> {code}
> has a null check for String "s", this method has no null check:
> {code}
> public static List<NameValuePair> parse(String s, Charset charset)
> {code}
> For consistency and backward compatibility reasons I recommend adding a null
> check there.
> Furthermore I would delegate to the method with separators:
> {code}
> public static List<NameValuePair> parse(String s, Charset charset) {
> return URLEncodedUtils.parse(s, charset, '&', ';');
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
