[ 
https://issues.apache.org/jira/browse/HTTPCORE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458142#comment-15458142
 ] 

ASF GitHub Bot commented on HTTPCORE-431:
-----------------------------------------

GitHub user pauldraper opened a pull request:

    https://github.com/apache/httpcore/pull/30

    HTTPCORE-431 Correct default encoding for application/json

    Auto-detect UTF encoding as described in RFC 4627/7159, including BOM 
handling

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pauldraper/httpcore pauldraper-HTTPCORE-431

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcore/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 24129b8cbca214d21c59bfb10796d04467e59926
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-10-21T11:58:45Z

    Changed project version to 5.0-alpha1-SNAPSHOT; disabled Clirr plugin
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1633350 
13f79535-47bb-0310-9956-ffa450edef68

commit 40543fde132b411c36637b526ff3a83ba5a34c82
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-10-24T07:14:07Z

    Removed deprecated classes
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1634008 
13f79535-47bb-0310-9956-ffa450edef68

commit b3d71c9e3cc858672f1e8893a305d8384f4ff4e3
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-10-24T07:14:58Z

    Removed deprecated code
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1634009 
13f79535-47bb-0310-9956-ffa450edef68

commit e715ed5f59063600bc0962c9ec66290b56cdc1c2
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-10-24T07:15:19Z

    Refactored message element iterator classes
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1634010 
13f79535-47bb-0310-9956-ffa450edef68

commit d3273a3f016f2d83bb0591149ec0e709647f363c
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-01T14:39:34Z

    Removed EncodingUtils
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1635958 
13f79535-47bb-0310-9956-ffa450edef68

commit ea3e821e448332c5523c09f4d442860b780f9e6c
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-01T14:40:07Z

    Optimization and cleanup of message parsing and formatting code
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1635959 
13f79535-47bb-0310-9956-ffa450edef68

commit 791dfda4280795064059c3a94699df9b0e4df73d
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-04T20:03:17Z

    TokenParser to use CharSequence instead of CharArrayBuffer
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1636717 
13f79535-47bb-0310-9956-ffa450edef68

commit 0711523f394d20a96237ee449eb37ba7dac08472
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-04T20:03:42Z

    Always use CharArrayBuffer when reading from / writing to session input / 
output buffers
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1636718 
13f79535-47bb-0310-9956-ffa450edef68

commit 20a02615236595bb3f09adfafaee7592617a89d2
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-04T20:03:53Z

    Added method to NHttpConnection to test availability of input data
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1636719 
13f79535-47bb-0310-9956-ffa450edef68

commit ab096e94b83dc9cd92f93dcee61757068713f51e
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-04T20:04:10Z

    Eliminated HttpInetConnection interface
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1636720 
13f79535-47bb-0310-9956-ffa450edef68

commit c2fd8375802f73645245e42a4977d8d97908ccc6
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-04T20:04:23Z

    Removed RFC 2616 specific javadoc
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1636721 
13f79535-47bb-0310-9956-ffa450edef68

commit 4d675f1e0fbc7c0ec5d6b3d7c4579eb036b3a9b0
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-04T20:04:40Z

    Moved blocking I/O specific connections methods to BHttpConnection interface
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1636722 
13f79535-47bb-0310-9956-ffa450edef68

commit e9cae1ce27734a8de884635d43b139658dc40a0a
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-04T20:04:58Z

    Drop support for Cloneable interface
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1636723 
13f79535-47bb-0310-9956-ffa450edef68

commit 9fcc88cf39bf357fc0bf35835bc76c5e6b93e35b
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-04T20:05:10Z

    Deleted EntityTemplate
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1636724 
13f79535-47bb-0310-9956-ffa450edef68

commit dd6f34907bba7a7d5974937eb932875ecf77092a
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-10T19:41:09Z

    Removed custom #hashCode and #equals methods that do not correctly reflect 
object identity
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1637960 
13f79535-47bb-0310-9956-ffa450edef68

commit a9cf155164595c398dd6593c6b24cc7d6bae950b
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-10T19:41:26Z

    Use CharSequence instead of CharArrayBuffer for header element parsing
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1637961 
13f79535-47bb-0310-9956-ffa450edef68

commit 0c075d9bc5a139ae24240da4cecb238c966be7ce
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-11T20:27:38Z

    AbstractHttpMessage to extend HeaderGroup
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1638359 
13f79535-47bb-0310-9956-ffa450edef68

commit 3d84cab610c085ea06f782a2738d0f4fbde9b5c7
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-11T20:27:55Z

    Blocking HttpEntity classes to implement HttpContentProducer interface; 
code clean in HttpEntity classes
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1638360 
13f79535-47bb-0310-9956-ffa450edef68

commit 3607e48e8d30559af9fbdff07129e2034f460dd0
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-11T20:28:06Z

    Code cleanup in ContentType class
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1638361 
13f79535-47bb-0310-9956-ffa450edef68

commit 0c0fc984451e5a6c14bba6be34988b7d52a0b8bc
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-11T20:53:35Z

    adding a callback to be executed when reusing an established connection 
from the pool
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1638390 
13f79535-47bb-0310-9956-ffa450edef68

commit d75400a7ea4e851f66ac1ceb84e60f3da3a19b16
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-14T17:17:52Z

    Removed HTTP class in favor of HttpHeaders and HeaderElements classes
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1639706 
13f79535-47bb-0310-9956-ffa450edef68

commit bb2a544689ecc243c44fdc25ce1b3147212d2dd1
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-14T17:21:50Z

    Set EmptyInputStream in entity instead of 
ContentLengthInputStream(inbuffer, 0)
    Contributed by Dmitry Potapov <dpotapov at yandex-team.ru>
    
    
    Conflicts:
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1639708 
13f79535-47bb-0310-9956-ffa450edef68

commit b9a6d56e5f10f686a10a839ce0b94c464dc9cf57
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-26T20:28:57Z

    Refactored HTTP message parsing APIs
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1641927 
13f79535-47bb-0310-9956-ffa450edef68

commit c3e967ad15b5a4f260fbb624b4086af42776d9fa
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-26T20:29:18Z

    Eliminated BufferInfo interface
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1641928 
13f79535-47bb-0310-9956-ffa450edef68

commit cac28e8b94338b2c29dbfb2725d37da67d301893
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-26T20:29:33Z

    Missing @Override annotations
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1641929 
13f79535-47bb-0310-9956-ffa450edef68

commit 5e59c81448b731adabd0055c995c7137ba9d7803
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-11-26T20:30:08Z

    RFC 7230: it is legal for any request method to enclose an entity; revised 
message delineation logic; removes HttpEntityEnclosingRequest interface; fixes 
HTTPCORE-318, HTTPCORE-380
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1641930 
13f79535-47bb-0310-9956-ffa450edef68

commit 537f205dec628c52ee88e865ca1a6f3a36f607ca
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-12-07T19:20:38Z

    Added methods to create ContentType with arbitrary parameters
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1643712 
13f79535-47bb-0310-9956-ffa450edef68

commit 4a827d5a673818d3352ef45cde657655addf2a31
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-12-09T09:34:59Z

    HTTPCLIENT-1585: SSLContextBuilder to preserve natural order of trust / key 
managers when loading trust / ket material from multiple sources
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1644009 
13f79535-47bb-0310-9956-ffa450edef68

commit b76d6c5e03efb9ca1ba53dbe49e2e792bd1dc0ad
Author: Oleg Kalnichevski <[email protected]>
Date:   2014-12-09T09:43:24Z

    Added @Obsolete and @Experimental annotations
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1644012 
13f79535-47bb-0310-9956-ffa450edef68

commit 57890e101fc60be42dad14412666c91b391b3642
Author: Sebastian Bazley <[email protected]>
Date:   2014-12-09T14:37:14Z

    HTTPCLIENT-1587 Document default Oracle JSSE restriction: SSLContext#init 
only uses first instance of managers
    
    git-svn-id: 
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk@1644064 
13f79535-47bb-0310-9956-ffa450edef68

----


> Correct character encoding default for application/json
> -------------------------------------------------------
>
>                 Key: HTTPCORE-431
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-431
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore
>            Reporter: Paul Draper
>            Priority: Minor
>
> RFC 4627 and RFC 7159 require that parsers auto-detect the encoding of 
> application/json. UTF-8 is the suggested default, though it's possible to 
> detect the encoding of valid JSON unambiguously.
> Currently, EntityUtils.toString defaults to ISO-8859-1 (the default for text 
> formats without a charset parameter).
> Given how common application/json is, it would be great for 
> EntityUtils.toString to use the correct encoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to