[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Kalnichevski updated HTTPCLIENT-1825:
------------------------------------------
    Labels: volunteers-wanted  (was: )

Proper async caching can now be implemented using the new async request exec 
interceptor API. Volunteers welcome.

https://github.com/apache/httpclient/blob/trunk/httpclient5/src/examples/org/apache/hc/client5/http/examples/AsyncClientInterceptors.java

Oleg

> CachingHttpAsyncClient does not follow same pattern as Caching HttpClient 
> --------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1825
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1825
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>            Reporter: Matt Inger
>              Labels: volunteers-wanted
>             Fix For: 5.0
>
>
> I would have expected the Caching version of the HttpAsyncClient library to 
> following same pattern as the non async version.  In the non-async version, 
> we have a CachingHttpClientBuilder class which extends the HttpClientBuilder, 
> and they both end up returning the same client implementation:  
> CloseableHttpClient.  
> I would have expected the same from the async version.  Instead it uses 
> CachingHttpAsyncClient as a decorator approach.
> This is unfortunate, because i really want to be able to not care about the 
> implementation and do this:
>     CloseableHttpAysncClient client = clientFactory.create("test");
> But i cannot do this, due to the design.  I also considered this:
>     HttpAysncClient client = clientFactory.create("test");
> But this does not guarantee that it implements Closeable, and in fact, 
> CachingHttpAsyncClient does not implement that interface.
> I'd like to see it more in line with the synchronous version.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to