[
https://issues.apache.org/jira/browse/HTTPCLIENT-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053204#comment-16053204
]
Oleg Kalnichevski commented on HTTPCLIENT-1857:
-----------------------------------------------
Rodolfo,
Are you sure this is the right thing to do? What should happen if the response
entity content has not been consumed or partially consumed. Are you sure this
is a good idea to re-use connections in such cases?
Oleg
> HttpClient falsely closes a reusable connection
> -----------------------------------------------
>
> Key: HTTPCLIENT-1857
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1857
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Reporter: Rodolfo Udo Labsch
> Attachments: ConnectionHolder.patch
>
>
> If you create a code with a reusable httpclient and then call execute as in
> the example with the following code. The http connection will be falsely
> closed.
> {code:java}
> private PoolingHttpClientConnectionManager connectionManager = new
> PoolingHttpClientConnectionManager();
> httpClient = HttpClients.custom()
> .setConnectionManager(connectionManager)
> .build();
> try (CloseableHttpResponse response = httpClient.execute(new
> HttpGet(enetLink), context)) {
> .....
> }
> {code}
> The reason being that we have:
> {code:java}
> CloseableHttpResponse:
> public void close() throws IOException {
> if (this.connHolder != null) {
> this.connHolder.close();
> }
> }
> ConnectionHolder:
> public void close() throws IOException {
> releaseConnection(false);
> }
> {code}
> Just created the correction, which is attached as patch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
