[
https://issues.apache.org/jira/browse/HTTPCORE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355559#comment-16355559
]
Gary Gregory commented on HTTPCORE-510:
---------------------------------------
Hi Oleg,
Thank you for the review.
It looks like I conflated the change with HTTPCORE-511 in
8d938a656f0db340b255112f0e97ae71e06e7886.
Gary
> Avoid an ArithmeticException in AbstractMultiworkerIOReactor by failing
> earlier by checking ioThreadCount in IOReactorConfig constructor.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HTTPCORE-510
> URL: https://issues.apache.org/jira/browse/HTTPCORE-510
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Priority: Major
> Fix For: 4.4.10, 5.0-beta3
>
>
> Avoid an {{ArithmeticException}} in {{AbstractMultiworkerIOReactor}} by
> failing eariler by checking {{ioThreadCount}} in {{IOReactorConfig}}
> constructor.
> If you build an {{IOReactorConfig}} with an {{ioThreadCount}} equal to 0, you
> will get the exception below. This can be avoided by failing earlier in the
> {{IOReactorConfig}} constructor.
> {noformat}
> java.lang.ArithmeticException: / by zero
> at
> org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor.addChannel(AbstractMultiworkerIOReactor.java:473)
> ~[httpcore-nio-4.4.9.jar:4.4.9]
> at
> org.apache.http.impl.nio.reactor.DefaultListeningIOReactor.processEvent(DefaultListeningIOReactor.java:189)
> ~[httpcore-nio-4.4.9.jar:4.4.9]
> at
> org.apache.http.impl.nio.reactor.DefaultListeningIOReactor.processEvents(DefaultListeningIOReactor.java:151)
> ~[httpcore-nio-4.4.9.jar:4.4.9]
> at
> org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor.execute(AbstractMultiworkerIOReactor.java:348)
> ~[httpcore-nio-4.4.9.jar:4.4.9]
> {noformat}
> Instead of the above, you will get an {{IllegalArgumentException}} from the
> {{IOReactorConfig}} constructor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
