[
https://issues.apache.org/jira/browse/HTTPCORE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457615#comment-16457615
]
Oleg Kalnichevski commented on HTTPCORE-525:
--------------------------------------------
Would you be able to make the proposed changes and submit them with a PR at
GitHub?
Oleg
> AuditLog should be a one of strategies rather than the only implementation
> --------------------------------------------------------------------------
>
> Key: HTTPCORE-525
> URL: https://issues.apache.org/jira/browse/HTTPCORE-525
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 5.0-beta2
> Reporter: Constantine Plotnikov
> Priority: Major
>
> The method requester.getExceptionLog() returns a list of exceptions that
> happened during execution. This creates potential memory leak.
> I think that this method should be removed, and replaced with some
> Consumer<Exception> or better Consumer<Throwable>. Or maybe some specialized
> interface. For backward compatibility, some default impelemtation of this
> interace could expose itself via getExceptionLog() method. But I think that
> this is excessive and those who need them as list might plug listener that
> collects them.
> Practially no application needs these exceptions as list. Most application
> need just to log these exception and forget about them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
