ok2c commented on a change in pull request #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#discussion_r256437720
##########
File path: httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java
##########
@@ -129,7 +129,8 @@ public static URI createURI(
public static URI rewriteURI(
final URI uri,
final HttpHost target,
- final boolean dropFragment) throws URISyntaxException {
+ final boolean dropFragment,
Review comment:
@cstamas Is there any chance you could avoid using multiple boolean
parameters and replace them with an enum?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
