On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote: > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > > > That sounds nice. > > > > > > Can we agree to add trivial changes to master directly, for > > > example, > > > if I > > > want to Javadoc a previously undocumented method? > > > > > > > I disagree rather strongly, especially if we want to keep master > > branch > > protected. Even trivial changes can break the build and introduce > > style > > violations. > > That's fair. That would mean we have a multibranch pipeline setup on > Jenkins. > Do we? If it doesn't fail there, it should be good for a PR or merge. > totally > fine by me. >
We have got Travis-CI right now and the multibranch pipeline setup on ASF Jenkins is something I would like to look into. Oleg > > > Gary > > > > > > On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski < > > > ol...@apache.org> > > > wrote: > > > > > > > Folks > > > > > > > > Since HttpComponents migration to GitBox I have been committing > > > > all > > > > my > > > > code changes to a feature branch and leaving them sit there for > > > > a > > > > day > > > > or two prior to merging them to a development branch (master or > > > > stable > > > > version branches). > > > > > > > > If there is anyone interested in doing formal code reviews of > > > > my > > > > changes please do let me know. I'll start raising PRs at GitHub > > > > for > > > > all > > > > my feature branches. > > > > > > > > Cheers > > > > > > > > Oleg > > > > > > > > > > > > ------------------------------------------------------------- > > > > ---- > > > > ---- > > > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > > > > > > > > > > ----------------------------------------------------------------- > > ---- > > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > > For additional commands, e-mail: dev-h...@hc.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
