rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256973407
##########
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
##########
@@ -91,33 +100,33 @@ private void createBytes(final Serializable ser) throws
IOException {
}
@Override
- public InputStream getContent() throws IOException, IllegalStateException {
+ public final InputStream getContent() throws IOException,
IllegalStateException {
if (this.objSer == null) {
createBytes(this.objRef);
Review comment:
Based on this (apparent) lazy initialization path, this class is not
currently immutable in any sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
