+1
>From src zip:

ASC OK
SHA512 OK

RAT check OK: mvn apache-rat:check
Clirr check OK: mvn clirr:check -P!use-toolchains

OK testing 'mvn clean package -V -P!use-toolchain' with Oracle Java 8:

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T14:41:47-04:00)
Maven home: C:\Java\apache-maven-3.6.0\bin\..
Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_202\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Then OK testing 'mvn test -V -P!use-toolchain' with OpenJDK 11.0.2:

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T14:41:47-04:00)
Maven home: C:\Java\apache-maven-3.6.0\bin\..
Java version: 11.0.2, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-11.0.2
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Then CANNOT test 'mvn test -V -P!use-toolchain' with OpenJDK 12:

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T14:41:47-04:00)
Maven home: C:\Java\apache-maven-3.6.0\bin\..
Java version: 12, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-12
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Because:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] Source option 6 is no longer supported. Use 7 or later.
[ERROR] Target option 6 is no longer supported. Use 7 or later.
[INFO] 2 errors

I'm not sure why Maven insists on recompiling but there you have it.

Gary



On Tue, Mar 26, 2019 at 10:38 AM Oleg Kalnichevski <ol...@apache.org> wrote:

> Please vote on releasing these packages as HttpClient 4.5.8.
> The vote is open for the at least 72 hours, and only votes from
> HttpComponents PMC members are binding. The vote passes if at least
> three binding +1 votes are cast and there are more +1 than -1 votes.
>
> Release notes:
>
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.5.8-RC1/RELEASE_NOTES-4.5.x.txt
>
> Maven artefacts:
>
> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1094/org/apache/httpcomponents/
>
> Git Tag: 4.5.8-RC1
>  https://github.com/apache/httpcomponents-client/tree/4.5.8-RC1
>
> Packages:
>
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-4.5.8-RC1
>  revision 33201
>
> Hashes:
>  
> acf43f783e18d2e9bbcadc09a6e54fb962508e3682281768307c553d2547906c9f93988f67c6ba9f3e4443952514593875541244fae486c10f41c17d11630336
> httpcomponents-client-4.5.8-bin.tar.gz
>  
> e990705105e93067be115b2ec9d92650c30e4228a2e35e9a2fe8041b4b8c62fa7696972bb3691de331d16d8a1adb0e93dabbf15bcc0088c296669b2a8b27d0bd
> httpcomponents-client-4.5.8-src.zip
>  
> 0730de98696dd97b669a157a1fdfb74a56d21d9dc04266ffe80e06a02cf5463ac85130262dc91fcc27ac6672ba38c51f6f5379e4667959254377d2cb8b6ddd19
> httpcomponents-client-4.5.8-src.tar.gz
>  
> e4653ba14dd7906afdf572c417e836edd1a4edc3217e3218c1fab300df8274de1cd1b8ff89f2342274f2e12db507734736356d320adc887a2ee79e91f424f785
> httpcomponents-client-4.5.8-bin.zip
>
> Keys:
>  http://www.apache.org/dist/httpcomponents/httpclient/KEYS
>
> --------------------------------------------------------------------------
> Vote: HttpClient 4.5.8 release
> [ ] +1 Release the packages as HttpClient 4.5.8.
> [ ] -1 I am against releasing the packages (must include a reason).
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
> For additional commands, e-mail: dev-h...@hc.apache.org
>
>

Reply via email to