ok2c commented on a change in pull request #155: Fix PublicSuffixMatcher for
wildcard domains
URL:
https://github.com/apache/httpcomponents-client/pull/155#discussion_r298120071
##########
File path:
httpclient5/src/test/java/org/apache/hc/client5/http/psl/TestPublicSuffixMatcher.java
##########
@@ -70,6 +70,8 @@ public void testGetDomainRoot() throws Exception {
Assert.assertEquals("blah.ac.jp",
matcher.getDomainRoot("blah.blah.ac.jp"));
Assert.assertEquals("garbage", matcher.getDomainRoot("garbage"));
Assert.assertEquals("garbage.garbage",
matcher.getDomainRoot("garbage.garbage"));
+ Assert.assertEquals("garbage.garbage",
matcher.getDomainRoot("garbage.garbage.garbage.garbage"));
+ Assert.assertEquals("garbage.garbage",
matcher.getDomainRoot("*.garbage.garbage"));
Review comment:
@jeromedemangel I do not think this is correct. The registerable part of
`garbage.garbage` should be `garbage`. Please see b6c9688.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
