[ 
https://issues.apache.org/jira/browse/HTTPCORE-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Linton Miller updated HTTPCORE-592:
-----------------------------------
    Description: 
The release method of LaxConnPool has a stray listener.onLease call that should 
not be there in the release method:

 
{code:java}
    public void release(final PoolEntry<T, C> entry, final boolean reusable) {
        ...
        final PerRoutePool<T, C> routePool = getPool(entry.getRoute());
        if (connPoolListener != null) {
            connPoolListener.onLease(entry.getRoute(), this);
        }
        routePool.release(entry, reusable);
    }
{code}
 

  was:
The release method of LaxConnPool has a stray listener.onLease call that should 
be there in the release method:

 
{code:java}
    public void release(final PoolEntry<T, C> entry, final boolean reusable) {
        ...
        final PerRoutePool<T, C> routePool = getPool(entry.getRoute());
        if (connPoolListener != null) {
            connPoolListener.onLease(entry.getRoute(), this);
        }
        routePool.release(entry, reusable);
    }
{code}
 


> LaxConnPool incorrectly notifies pool listener of lease on release
> ------------------------------------------------------------------
>
>                 Key: HTTPCORE-592
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-592
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore
>    Affects Versions: 5.0-beta8
>            Reporter: Linton Miller
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The release method of LaxConnPool has a stray listener.onLease call that 
> should not be there in the release method:
>  
> {code:java}
>     public void release(final PoolEntry<T, C> entry, final boolean reusable) {
>         ...
>         final PerRoutePool<T, C> routePool = getPool(entry.getRoute());
>         if (connPoolListener != null) {
>             connPoolListener.onLease(entry.getRoute(), this);
>         }
>         routePool.release(entry, reusable);
>     }
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to