michael-o commented on a change in pull request #159: Development
URL:
https://github.com/apache/httpcomponents-core/pull/159#discussion_r344216229
##########
File path:
httpcore5/src/main/java/org/apache/hc/core5/reactor/IOReactorConfig.java
##########
@@ -205,31 +205,31 @@ public static Builder copy(final IOReactorConfig config)
{
public static class Builder {
- private static int DefaultMaxIoThreadCount = -1;
+ private static int DEF_MAX_IO_THREAD_COUNT = -1;
Review comment:
The convention says that only final static values are uppercase. This is a
variable which can be mutated, hence it should follow general camel case rules:
`defaultMaxIOThreadCount`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
