nielsbasjes commented on issue #174: HTTPCLIENT-2030: Fix PublicSuffixMatcher::getDomainRoot on invalid hostnames URL: https://github.com/apache/httpcomponents-client/pull/174#issuecomment-558569799 I have added an optional DomainType parameter to the DefaultHostnameVerifier in case a PublicSuffixMatcher is specified. The default value is null if not specified because that matches the behavior as it currently is. I handled the review comments. Did a rebase against the latest master. @ok2c Please review.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
