[ https://issues.apache.org/jira/browse/HTTPCORE-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005768#comment-17005768 ]
Michael Osipov commented on HTTPCORE-620: ----------------------------------------- Fully agree with [~olegk], {{#compareTo()}} is more than enough. > Refactor int constants from org.apache.hc.core5.reactor.IOSession into an enum > ------------------------------------------------------------------------------ > > Key: HTTPCORE-620 > URL: https://issues.apache.org/jira/browse/HTTPCORE-620 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore > Reporter: Gary D. Gregory > Priority: Major > > Refactor int constants fromĀ {{org.apache.hc.core5.reactor.IOSession}} into an > enum called state: > * {color:#500050}int > org.apache.hc.core5.reactor.IO{color}{color:#500050}Session.ACTIVE{color} > * {color:#500050}int > org.apache.hc.core5.reactor.IO{color}{color:#500050}Session.CLOSED{color} > * {color:#500050}int > org.apache.hc.core5.reactor.IO{color}{color:#500050}Session.CLOSING{color} > Like: > {code:java} > public interface IOSession extends ByteChannel, SocketModalCloseable, > Identifiable { > public enum Status { > ACTIVE(0), > CLOSING(1), > CLOSED(Integer.MAX_VALUE); > private Status(final int rank) { > this.rank = rank; > } > public final int rank; > } > ... > {code} > PR coming... -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org