It looks like we already have logic from the Apache 4 integration that will handle consecutive slashes:
https://github.com/aws/aws-sdk-java-v2/blob/2a303333f2b349209918a857a860266bb46102c2/http-clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/internal/impl/ApacheHttpRequestFactory.java#L64-L75 To be honest, I don't have a very deep understanding of what all the fuss was about last time around, and I still need to investigate and test this when I get back in the office tomorrow. On Wed, Jan 1, 2020 at 5:43 AM Oleg Kalnichevski <[email protected]> wrote: > On Tue, 2019-12-31 at 14:02 -0800, Ryan Schmitt wrote: > > I read through that, but I didn't see a specific explanation of what > > would > > need to be fixed and how. > > > > Either way, it's not really interesting. I need to be able to call S3 > > as-is, warts and all, or the client is unusable. > > > > On Tue, Dec 31, 2019 at 12:48 PM Michael Osipov <[email protected]> > > wrote: > > > > > Am 2019-12-31 um 20:01 schrieb Michael Osipov: > > > > Am 2019-12-31 um 19:50 schrieb Ryan Schmitt: > > > > > I don't have anything open for the next beta release. However, > > > > > before > > > > > we do > > > > > a GA release, I need to investigate how URI normalization > > > > > currently > > > > > > works > > > > > in 5.x. The URI normalization changes in 4.5.x caused a lot of > > > > > problems for > > > > > the AWS SDK, so I want to make sure we don't get off on the > > > > > wrong foot. > > > > > > Hi Ryan > > The latest versions of both HttpClient 4.5 and HttpClient 5.0 only re- > encode the path component only if contains multiple consecutive > slashes, otherwise the original encoding is preserved as is. I presume > this should be good enough for the greatest majority of users. > > Oleg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
