Torsten Rendelmann created HTTPCORE-628:
-------------------------------------------

             Summary: URIBuilder:: query parameters are encoded differently 
compared to java.lang.URI
                 Key: HTTPCORE-628
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-628
             Project: HttpComponents HttpCore
          Issue Type: Bug
          Components: HttpCore
    Affects Versions: 5.0
         Environment: Java EE; Vaadin; Glassfish 5
            Reporter: Torsten Rendelmann
             Fix For: Future


If we build an URI using java.lang.URI, the encoding of the query parameters 
are different compared to build the URI using URIBuilder. The URIBuilder uses 
e.g. "+" to encode spaces (by default) while java.lang.URI uses (the expected) 
"%20" hex encoding for spaces.

Test that show the problem:
{code:java}
@Test
public void testAddParameterEncodingEquivalence() throws Exception {
    final URI uri = new URI("http", null, "localhost", 80, "/",
            "param=stuff with spaces", null);
    final URIBuilder uribuilder = new 
URIBuilder().setScheme("http").setHost("localhost").setPort(80).setPath("/").addParameter(
            "param", "stuff with spaces");
    final URI result = uribuilder.build();
    Assert.assertEquals(uri, result);
}
{code}
Think, there is a platform mismatch the URIBuilder is thought to be used: the 
current implementation focus on server site to build URI to be used in http 
post/put; not for a simple http get as it is also been used on client site (by 
browsers, or vaadin apps). Would be fine if we could control the use target 
from outsite; e.g. as a build() call parameter, or separate buildUrlEncoded() 
using "%20" and build() use the current implementation?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to