carterkozak edited a comment on pull request #206: URL: https://github.com/apache/httpcomponents-core/pull/206#issuecomment-668610861
@michael-o It's not easy to test with the client module, I think our options are: 1. Write a custom `HttpConnectionFactory<ManagedHttpClientConnection>` implementation which returns a new `ManagedHttpClientConnection` implementation extending `DefaultBHttpClientConnection` and implementing `ManagedHttpClientConnection`. This is the approach I took to work around the issue originally here: https://github.com/palantir/dialogue/pull/917/files 2. Test using a RequesterBootstrap based on the test from #207 https://github.com/apache/httpcomponents-core/pull/207/files#diff-082ca5e3279571aba16c172e7cc4b791 I can put together a quick `HttpConnectionFactory<ManagedHttpClientConnection>` implementation for you if you like. edit with additional explanation: The httpcomponents-client `ManagedHttpClientConnectionFactory` duplicates most of httpcomponents-core `DefaultBHttpClientConnectionFactory` in order to return a `DefaultManagedHttpClientConnection` which extends `DefaultBHttpClientConnection`. It might be helpful if we implemented an adapter to allow the factory from core to be used more directly, something like this: https://github.com/apache/httpcomponents-client/pull/243 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
