ok2c commented on a change in pull request #296:
URL:
https://github.com/apache/httpcomponents-client/pull/296#discussion_r598096418
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java
##########
@@ -42,8 +42,6 @@
@Contract(threading = ThreadingBehavior.IMMUTABLE)
public class RequestConfig implements Cloneable {
- private static final Timeout DEFAULT_CONNECTION_REQUEST_TIMEOUT =
Timeout.ofMinutes(3);
- private static final Timeout DEFAULT_CONNECT_TIMEOUT =
Timeout.ofMinutes(3);
private static final TimeValue DEFAULT_CONN_KEEP_ALIVE =
TimeValue.ofMinutes(3);
Review comment:
@michael-o You are correct. This is a request level parameter. I will
keep it in `RequestConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
