michael-o commented on a change in pull request #296:
URL: 
https://github.com/apache/httpcomponents-client/pull/296#discussion_r601292659



##########
File path: 
httpclient5-fluent/src/main/java/org/apache/hc/client5/http/fluent/Executor.java
##########
@@ -64,7 +65,9 @@
                         .useSystemProperties()
                         .setMaxConnPerRoute(100)
                         .setMaxConnTotal(200)
-                        .setValidateAfterInactivity(TimeValue.ofSeconds(10))
+                        
.setDefaultConnectionMgmtConfig(ConnectionMgmtConfig.custom()

Review comment:
       @carterkozak I wonder why we need `Mgmt` at all. Do we have 
`RequestMmgtConfig`. `ConnectionMgmt..` makes sense when it has influence on 
the connection tool manager. Then it makes sense, but a full word is better to 
me too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to