michael-o commented on a change in pull request #296:
URL:
https://github.com/apache/httpcomponents-client/pull/296#discussion_r602084880
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
##########
@@ -221,6 +229,7 @@ private InternalConnectionEndpoint cast(final
AsyncConnectionEndpoint endpoint)
LOG.debug("{} endpoint lease request ({}) {}", id, requestTimeout,
ConnPoolSupport.formatStats(route, state, pool));
}
final ComplexFuture<AsyncConnectionEndpoint> resultFuture = new
ComplexFuture<>(callback);
+ final ConnectionConfig connMgmtConfig = resolveConnectionConfig(route);
Review comment:
Mgmt leftover?
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
##########
@@ -242,7 +251,7 @@ void leaseCompleted(final PoolEntry<HttpRoute,
ManagedAsyncClientConnection> poo
@Override
public void completed(final PoolEntry<HttpRoute,
ManagedAsyncClientConnection> poolEntry) {
final ManagedAsyncClientConnection connection =
poolEntry.getConnection();
- final TimeValue timeValue =
PoolingAsyncClientConnectionManager.this.validateAfterInactivity;
+ final TimeValue timeValue = connMgmtConfig != null ?
connMgmtConfig.getValidateAfterInactivity() : null;
Review comment:
Mgmt leftover?
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
##########
@@ -357,6 +365,9 @@ public void release(final AsyncConnectionEndpoint endpoint,
final Object state,
host = route.getTargetHost();
}
final InetSocketAddress localAddress = route.getLocalSocketAddress();
+ final ConnectionConfig connMgmtConfig = resolveConnectionConfig(route);
Review comment:
Mgmt leftover?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
