[
https://issues.apache.org/jira/browse/HTTPCORE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341530#comment-17341530
]
Oleg Kalnichevski commented on HTTPCORE-677:
--------------------------------------------
[~pierz] This is an abnormal situation in my opinion because the client is
supposed to communicate ins intent to close the connection by sending
`Connection: close` header. It is much neater from the API perspective to
signal this event through an exception instead of returning a null request
object. What I could do is catch ConnectionClosedException here [1] and quietly
discard it
Oleg
[1]
https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/Worker.java#L66
> Suggestion: Don't throw ConnectionClosedException when connection close is
> expected
> -----------------------------------------------------------------------------------
>
> Key: HTTPCORE-677
> URL: https://issues.apache.org/jira/browse/HTTPCORE-677
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 5.1
> Reporter: Pierre N.
> Priority: Major
> Fix For: 5.1.1
>
>
> I'm testing apache core to replace Undertow in my web app so maybe I
> configured badly but I noticed the server is throwing an exception in
> ExceptionListener every time a client connection is closed.
> Is it necessary ? Is it really exceptional ? Do we really need to build a
> full stacktrace every time a socket is closed because it happens a lot.
> The connection is expected to be closed at some point, I understand an
> exception could be thrown if it occurs will reading the request or the
> request body, but if the request has been read, I think it is not exceptional
> and it shouldn't throw.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
