ok2c commented on a change in pull request #333:
URL:
https://github.com/apache/httpcomponents-core/pull/333#discussion_r753673296
##########
File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java
##########
@@ -69,6 +73,27 @@ public void testConstructor() {
Assert.assertThrows(NullPointerException.class, () -> new
HttpHost(null, (String) null, -1));
Assert.assertThrows(IllegalArgumentException.class, () -> new
HttpHost(null, " ", -1));
Assert.assertThrows(NullPointerException.class, () -> new
HttpHost(null, (InetAddress) null, -1));
+
+ final Host host = new Host("myHost", 8080);
Review comment:
> I know. but it the same whit the Authority constructor
@arturobernalg It is not the same. The URI authority does not have a scheme
component.
> What you suggest that we should do?
I suggest that we do nothing. Not only this constructor is not very useful,
it can lead to incorrect / unpredictable results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
