ok2c commented on a change in pull request #343:
URL:
https://github.com/apache/httpcomponents-client/pull/343#discussion_r779044757
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncHttpRequestRetryExec.java
##########
@@ -128,6 +128,9 @@ public void handleInformationResponse(final HttpResponse
response) throws HttpEx
public void completed() {
if (state.retrying) {
scope.execCount.incrementAndGet();
+ if (entityProducer != null &&
entityProducer.isRepeatable()) {
Review comment:
@JasonMathison Damn. Good catch. However, I propose
`AsyncEntityProducer#isRepeatable` check be dropped here. At this point if the
entity producer is not null we should always call
`AsyncEntityProducer#releaseResources`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
