HI,

The java 17 issue —> The problem seem to be with easymock. There is an open 
thread.

https://github.com/easymock/easymock/issues/235 
<https://github.com/easymock/easymock/issues/235>



As for the ¨random failure” test, IMO  doest seem an error of the api,  It 
looks more like a missing/issue configuration/set up of the test .

As a provisional workaround we can ignored in case of error wight is if I 
remember correctly (Connection closed by peer).

try {
    final SimpleHttpResponse response = future.get(TIMEOUT.getDuration(), 
TIMEOUT.getTimeUnit());
    Assert.assertThat(response, CoreMatchers.notNullValue());
    Assert.assertThat(response.getCode(), CoreMatchers.equalTo(200));
} catch (final ExecutionException ignore) {
    // ignore
}


I’ve checking this release LGTM

So,


+1 Release the packages as HttpClient 5.1.3




Arturo Bernal
arturobern...@yahoo.com



> On 27 Jan 2022, at 14:53, Oleg Kalnichevski <ol...@apache.org> wrote:
> 
> On Thu, 2022-01-27 at 08:38 -0500, Gary Gregory wrote:
>> On Thu, Jan 27, 2022 at 8:31 AM Oleg Kalnichevski <ol...@apache.org>
>> wrote:
>> 
>>> On Thu, 2022-01-27 at 08:23 -0500, Gary Gregory wrote:
>>>> Testing with TAR GZ file and building from the git tag (HEAD
>>>> detached
>>>> at
>>>> 5.1.3-RC1).
>>>> 
>>>> ASC file is good.
>>>> Checksum OK.
>>>> 
>>>> Running 'mvn clean verify' fails randomly:
>>>> 
>>>> 
>>> 
>>> Making reliable test cases that simulate complex or abnormal
>>> situations
>>> is not easy. Testing request cancellation and its outcome was
>>> tricky. I
>>> will take a look at the test case but I am not sure it warrants a
>>> new
>>> RC.
>>> 
>> 
>> Thank you Oleg, I'll wait to hear from you before continuing to
>> review.
>> 
> 
> I will take a look at the test case but please continue the review and
> cast a vote.
> 
> Oleg
> 
> 
>> Gary
>> 
>> 
>>> Oleg
>>> 
>>> 
>>> 
>>>> [INFO] Running org.apache.hc.client5.testing.async.TestHttp1Async
>>>> [ERROR] Tests run: 24, Failures: 0, Errors: 1, Skipped: 0, Time
>>>> elapsed:
>>>> 0.832 s <<< FAILURE! - in
>>>> org.apache.hc.client5.testing.async.TestHttp1Async
>>>> [ERROR]
>>>> org.apache.hc.client5.testing.async.TestHttp1Async.testRequestCan
>>>> cell
>>>> ation[HTTP/1.1
>>>> https]  Time elapsed: 0.05 s  <<< ERROR!
>>>> java.util.concurrent.ExecutionException:
>>>> org.apache.hc.client5.http.HttpHostConnectException: Connect to
>>>> https://localhost:63965 [localhost/127.0.0.1,
>>>> localhost/0:0:0:0:0:0:0:1]
>>>> failed: Connection refused
>>>> at
>>>> org.apache.hc.client5.testing.async.TestHttp1Async.testRequestCan
>>>> cell
>>>> ation(TestHttp1Async.java:297)
>>>> Caused by: org.apache.hc.client5.http.HttpHostConnectException:
>>>> Connect to
>>>> https://localhost:63965 [localhost/127.0.0.1,
>>>> localhost/0:0:0:0:0:0:0:1]
>>>> failed: Connection refused
>>>> 
>>>> Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
>>>> Maven home: /usr/local/Cellar/maven/3.8.4/libexec
>>>> Java version: 1.8.0_312, vendor: Homebrew, runtime:
>>>> /usr/local/Cellar/openjdk@8/1.8.0+312/libexec/openjdk.jdk/Content
>>>> s/Ho
>>>> me/jre
>>>> Default locale: en_US, platform encoding: UTF-8
>>>> OS name: "mac os x", version: "12.1", arch: "x86_64", family:
>>>> "mac"
>>>> 
>>>> Darwin *** 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28
>>>> 20:28:54
>>>> PST
>>>> 2021; root:xnu-8019.61.5~1/RELEASE_X86_64 x86_64
>>>> 
>>>> Thoughts? I can't tell if this is a random test setup issue or a
>>>> deeper
>>>> underlying issue.
>>>> 
>>>> Gary
>>>> 
>>>> 
>>>> On Thu, Jan 27, 2022 at 7:59 AM Oleg Kalnichevski <
>>>> ol...@apache.org>
>>>> wrote:
>>>> 
>>>>> Please vote on releasing these packages as HttpClient 5.1.3.
>>>>> The vote is open for the at least 72 hours, and only votes from
>>>>> HttpComponents PMC members are binding. The vote passes if at
>>>>> least
>>>>> three binding +1 votes are cast and there are more +1 than -1
>>>>> votes.
>>>>> 
>>>>> Release notes:
>>>>> 
>>>>> 
>>> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-5.1.3-RC1/RELEASE_NOTES-5.1.x.txt
>>>>> Maven artefacts:
>>>>> 
>>>>> 
>>> https://repository.apache.org/content/repositories/orgapachehttpcomponents-1144/org/apache/httpcomponents/client5/
>>>>> Git Tag: 5.1.3-RC1
>>>>> https://github.com/apache/httpcomponents-client/tree/5.1.3-RC1
>>>>> 
>>>>> Packages:
>>>>> 
>>>>> 
>>> https://dist.apache.org/repos/dist/dev/httpcomponents/httpclient-5.1.3-RC1
>>>>> revision 52302
>>>>> 
>>>>> Hashes:
>>>>> 7ac9d37d1cc669a301b28c36b9aa03aa348112673082ced1c1cab4fd635724
>>>>> 6a08
>>>>> 5ea6ed499754ac25291b8649dcfe4e4e55385fa68a01b7e5971e25258103af
>>>>> httpcomponents-client-5.1.3-bin.tar.gz
>>>>> 73b659bd93bb977d499b5529ebfb65366236d3bc20892694043b99b79574ba
>>>>> 581f
>>>>> 812ba16426486b62c44ef9d04e4dd2802a6feab2a1135c511b19e28b1e726f
>>>>> httpcomponents-client-5.1.3-src.tar.gz
>>>>> 9a94499701319ce4e2b855ad5a5c6f907d9584727d1c6736bf237db45f0709
>>>>> 04f4
>>>>> c325f8b73702e94a23ba8474a169a8d4b0adc44800fa23c85f7f67805fe40f
>>>>> httpcomponents-client-5.1.3-bin.zip
>>>>> 745954fe17adf6da11a7ce70971d49e775f55b26be6e5e5bede509601878ce
>>>>> b941
>>>>> 09fa73c664dc007968fc3825340e299e13cb511199da04ec55e6ff1371fef4
>>>>> httpcomponents-client-5.1.3-src.zip
>>>>> 
>>>>> Keys:
>>>>> https://www.apache.org/dist/httpcomponents/httpclient/KEYS
>>>>> 
>>>>> -------------------------------------------------------------
>>>>> ----
>>>>> ---------
>>>>> Vote: HttpClient 5.1.3 release
>>>>> [ ] +1 Release the packages as HttpClient 5.1.3.
>>>>> [ ] -1 I am against releasing the packages (must include a
>>>>> reason).
>>>>> 
>>>>> 
>>>>> -------------------------------------------------------------
>>>>> ----
>>>>> ----
>>>>> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
>>>>> For additional commands, e-mail: dev-h...@hc.apache.org
>>>>> 
>>>>> 
>>> 
>>> -----------------------------------------------------------------
>>> ----
>>> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
>>> For additional commands, e-mail: dev-h...@hc.apache.org
>>> 
>>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org 
> <mailto:dev-unsubscr...@hc.apache.org>
> For additional commands, e-mail: dev-h...@hc.apache.org 
> <mailto:dev-h...@hc.apache.org>

Reply via email to