[ https://issues.apache.org/jira/browse/HTTPCLIENT-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505132#comment-17505132 ]
Oleg Kalnichevski commented on HTTPCLIENT-2209: ----------------------------------------------- > The change could be done in non-breaking fashion by adding default method > implementation. Happily to submit a patch if the improvement makes sense. [~reta] Please do. However, please do note this change can be made in master (5.2) only. Oleg > Pass HttpContext to AsyncClientConnectionOperator > ------------------------------------------------- > > Key: HTTPCLIENT-2209 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2209 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (async) > Affects Versions: 5.1.2 > Reporter: Andriy Redko > Priority: Major > > Although the *AsyncClientConnectionOperator* is primarily used by > *AsyncClientConnectionManager* implementation, the *HttpContext* is not > passed from *AsyncClientConnectionManager* to *AsyncClientConnectionOperator* > (the respective connect() and upgrade() methods just do nothing with it). > It significantly limits the context propagation abilities for > *AsyncClientConnectionOperator* implementations. Also, adding *HttpContext* > makes the *AsyncClientConnectionOperator* on par with > *HttpClientConnectionOperator* which accepts HttpContext. > The change could be done in non-breaking fashion by adding default method > implementation. Happily to submit a patch if the improvement makes sense. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org