carterkozak commented on code in PR #349:
URL:
https://github.com/apache/httpcomponents-core/pull/349#discussion_r889000388
##########
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestComplexFuture.java:
##########
@@ -96,4 +96,11 @@ public void completed(final Object result) {
assertThat(dependency2.isCancelled(), CoreMatchers.is(true));
}
+ @Test
+ public void testFailedAndFailed() {
+ final ComplexFuture<Object> future = new ComplexFuture<>(null);
+ future.cancel();
Review Comment:
Perhaps worth asserting that `cancel()` returns true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
