carterkozak commented on code in PR #371:
URL:
https://github.com/apache/httpcomponents-client/pull/371#discussion_r894801063
##########
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestConnectionReuse.java:
##########
@@ -197,8 +204,10 @@ public void testReuseOfAbortedConnections() throws
Exception {
}
}
- // Expect zero connections in the pool
- Assertions.assertEquals(0,
this.connManager.getTotalStats().getAvailable());
+ // Expect leased connections to be returned
+ Assertions.assertEquals(0,
this.connManager.getTotalStats().getLeased());
+ // Expect some connections in the pool
+ Assertions.assertTrue(this.connManager.getTotalStats().getAvailable()
> 0);
Review Comment:
Previously this test expected connections to be closed, however the response
was fully drained and ready for reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
