[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620106#comment-17620106
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-2239:
-----------------------------------------------

> It seems like you guys have a setter on the DefaultRequestConfig that not 
> only is not deprecated, but just doesn't do anything

[~patrickjamesbarry] It very much does. It works as advertised with the classic 
HttpClient.

> updating docs, adding javadoc, etc would be really helpful as well.

We are happy to take javadoc improvements as a PR at GitHub.

Oleg

> setContentCompressionEnabled(true) does not work
> ------------------------------------------------
>
>                 Key: HTTPCLIENT-2239
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2239
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (async)
>    Affects Versions: 5.1.3
>            Reporter: Patrick Barry
>            Priority: Major
>
> {code:java}
> CloseableHttpAsyncClient client = HttpAsyncClients.custom()
>         .disableAuthCaching()
>         .disableCookieManagement()
>         .setVersionPolicy(FORCE_HTTP_1)
>         .setDefaultRequestConfig(RequestConfig.custom()
>                 .setContentCompressionEnabled(true)
>                 .build())
>         .build(); 
> We are migrating away from old apache sync client in favor of 
> CloseableHttpAsyncClient. However, the new async client is not respecting the 
> client configuration of contentCompression.  The old client would call down 
> into ProtocolExec -> httpProcessor.process(request, context) -> which would 
> go into interceptor RequestAcceptEncoding and if you wanted compression, it 
> would add the Accept-Encoding header.  This new client is not doing that.    
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to