[
https://issues.apache.org/jira/browse/HTTPCLIENT-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701913#comment-17701913
]
Oleg Kalnichevski commented on HTTPCLIENT-1368:
-----------------------------------------------
[~arturobernalg] I have only a rudimentary understanding of the HTTP caching.
[~jonm] was the expect on the matter but he has retired from the project.
Having said that, I am not sure you are doing the right thing. From what I
understand the stale cache entries can be returned _only_ in case of an i/o
error or 500 status when _re-validating_ a stale cache entry. Your patch simply
returns stale cache entry without re-validation when the new config parameter
is set to true. This looks wrong to me.
Also, please do not forget there is the async protocol handing pipleline.
Things must work the same way with both the classic and async APIs.
Oleg
> stale-if-error request cache directive should also apply to non-revalidatable
> cache entries
> -------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1368
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1368
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpCache
> Affects Versions: 4.2.4, 4.2.5, 4.3 Beta1
> Reporter: Jonathan Moore
> Priority: Minor
> Labels: stuck, volunteers-wanted
> Fix For: Stuck
>
>
> The stale-if-error request cache directive is defined in RFC 5861:
> http://tools.ietf.org/html/rfc5861
> As implemented, this will only apply to cache entries that are revalidatable
> (i.e. they have an Etag or Last-Modified header and can be refreshed with a
> conditional request) but it should also apply to any stale cache entry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
