arturobernalg commented on code in PR #429:
URL:
https://github.com/apache/httpcomponents-client/pull/429#discussion_r1154321331
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java:
##########
@@ -81,14 +115,65 @@ public class HttpByteArrayCacheEntrySerializer implements
HttpCacheEntrySerializ
private static final String SC_HEADER_NAME_NO_CONTENT =
SC_CACHE_ENTRY_PREFIX + "no-content";
private static final String SC_HEADER_NAME_VARIANT_MAP_KEY =
SC_CACHE_ENTRY_PREFIX + "varmap-key";
private static final String SC_HEADER_NAME_VARIANT_MAP_VALUE =
SC_CACHE_ENTRY_PREFIX + "varmap-val";
-
private static final String SC_CACHE_ENTRY_PRESERVE_PREFIX =
SC_CACHE_ENTRY_PREFIX + "esc-";
- private static final int BUFFER_SIZE = 8192;
+ /**
+ * The generator used to generate cached HTTP responses.
+ */
+ private final CachedHttpResponseGenerator cachedHttpResponseGenerator;
+
+ /**
+ * The size of the buffer used for reading/writing data.
+ */
+ private final int bufferSize;
+
+ /**
+ * Use the default, ASCII-only encoder for HTTP protocol and header values.
+ * It's the only thing that's widely used, and it's not worth it to
support anything else.
+ */
+ private final SessionOutputBuffer outputBuffer;
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
