michael-o commented on code in PR #436:
URL:
https://github.com/apache/httpcomponents-client/pull/436#discussion_r1174606733
##########
httpclient5/src/main/java/org/apache/hc/client5/http/auth/NTCredentials.java:
##########
@@ -85,25 +89,46 @@ public NTCredentials(
* Essentially, the computer name for this machine.
* @param domain The domain to authenticate within.
* @param netbiosDomain The netbios version of the domain name.
+ @deprecated (5.3) Use {@link #NTCredentials(char[], String, String,
String)}
*/
+ @Deprecated
public NTCredentials(
final String userName,
final char[] password,
final String workstation,
final String domain,
final String netbiosDomain) {
+ this(password, userName, domain, netbiosDomain);
+ }
+
+ /**
+ * Constructor to create an instance of NTCredentials.
+ *
+ * @param password The password to use for authentication. Must not
be null.
+ * @param userName The user name for authentication. This should not
include the domain to authenticate with.
+ * For example: "user" is correct whereas
"DOMAIN\user" is not. Must not be null.
+ * @param domain The domain to authenticate within. Can be null.
+ * @param netbiosDomain The netbios version of the domain name. Can be
null.
Review Comment:
Yes, but there is no correlation to the NetBIOS *domain*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
