ok2c commented on PR #444: URL: https://github.com/apache/httpcomponents-client/pull/444#issuecomment-1537358368
@arturobernalg So much better. Almost there. Let's reduce the public API footprint a bit, though. Generally there should be no protected instance variables. It will be very difficult to change the internal structure of a class in the future if it has protected instance variables. Please make those variables private and provide protected getters for them. And there are still test case failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
