arturobernalg commented on PR #444:
URL:
https://github.com/apache/httpcomponents-client/pull/444#issuecomment-1537425052
> @arturobernalg So much better. Almost there. Let's reduce the public API
footprint a bit, though. Generally there should be no protected instance
variables. It will be very difficult to change the internal structure of a
class in the future if it has protected instance variables. Please make those
variables private and provide protected getters for them.
>
> And there are still test case failures.
@ok2c
I have made the previously protected instance variables private and
provided protected getters for them. This will help maintain encapsulation and
allow for easier changes to the internal structure of the class in the future.
Regarding the test case failures, I have reviewed and made adjustments to
the tests to minimize timing-related issues. Should be fine now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
