ok2c commented on code in PR #460:
URL:
https://github.com/apache/httpcomponents-client/pull/460#discussion_r1237675871
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicHttpAsyncCache.java:
##########
@@ -90,11 +91,15 @@ public BasicHttpAsyncCache(final ResourceFactory
resourceFactory, final HttpAsyn
@Override
public String generateKey(final HttpHost host, final HttpRequest request,
final HttpCacheEntry cacheEntry) {
- if (cacheEntry == null) {
- return cacheKeyGenerator.generateKey(host, request);
- } else {
- return cacheKeyGenerator.generateKey(host, request, cacheEntry);
+ final String root = cacheKeyGenerator.generateKey(host, request);
Review Comment:
@arturobernalg I am aware. I am working on a major refactoring of the
caching logic and those duplicate bits will go away. Ignore it for now and bear
with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
