ChristophKaser commented on code in PR #468:
URL:
https://github.com/apache/httpcomponents-client/pull/468#discussion_r1270291642
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java:
##########
@@ -323,7 +323,7 @@ public synchronized ConnectionEndpoint get(
final TimeValue timeToLive =
connectionConfig.getTimeToLive();
if (TimeValue.isNonNegative(timeToLive)) {
final Deadline deadline =
Deadline.calculate(poolEntry.getCreated(), timeToLive);
- if (deadline.isExpired()) {
+ if (timeValue.getDuration() == 0 ||
deadline.isExpired()) {
Review Comment:
1. Done - I have inlined the deadline calculation now.
2. Done
3. Ouch, very sorry about that. I had made the changes to an internal fork
and copied them into the vanilla project, but did not run `mvn verify` after
that. I have corrected the typo (and this time, I did run mvn).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
