ok2c commented on code in PR #425:
URL:
https://github.com/apache/httpcomponents-core/pull/425#discussion_r1311380711
##########
httpcore5/src/main/java/org/apache/hc/core5/http/message/MessageSupport.java:
##########
@@ -151,6 +152,11 @@ public static void addContentEncodingHeader(final
HttpMessage message, final Ent
}
public static void addTrailerHeader(final HttpMessage message, final
EntityDetails entity) {
+ // Ensure using chunked transfer encoding
Review Comment:
@arturobernalg Please, do not. This is very wrong on many levels. First off
`Transfer-Encoding` value is a not a single token, it is a comma delimited
sequence, like `this, that, chunk. Secondly off, this is absolutely the wrong
place to enforce the check. Thirdly it is not even necessary because the
`*tContent` protocol interceptors already take care of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
