ok2c commented on code in PR #449:
URL: 
https://github.com/apache/httpcomponents-core/pull/449#discussion_r1431391449


##########
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##########
@@ -967,7 +967,7 @@ public List<NameValuePair> getQueryParams() {
      * @since 5.2
      */
     public NameValuePair getFirstQueryParam(final String name) {
-        return queryParams.stream().filter(e -> 
name.equals(e.getName())).findFirst().orElse(null);

Review Comment:
   @skssxf Could you please do a null check here instead of creating an empty 
list here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to