ok2c commented on code in PR #535: URL: https://github.com/apache/httpcomponents-client/pull/535#discussion_r1449148318
########## httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java: ########## @@ -63,7 +63,7 @@ public PlainConnectionSocketFactory() { @Override public Socket createSocket(final Proxy proxy, final HttpContext context) throws IOException { - return proxy != null ? new Socket(proxy) : new Socket(); Review Comment: @twarner-sofi No, it is not. It is used by the default method of the interface. There is no breaking change ``` @Internal default Socket createSocket(Proxy proxy, HttpContext context) throws IOException { return createSocket(context); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org