ok2c commented on code in PR #535:
URL:
https://github.com/apache/httpcomponents-client/pull/535#discussion_r1453956084
##########
httpclient5/src/main/java/org/apache/hc/client5/http/socket/PlainConnectionSocketFactory.java:
##########
@@ -63,7 +63,7 @@ public PlainConnectionSocketFactory() {
@Override
public Socket createSocket(final Proxy proxy, final HttpContext context)
throws IOException {
- return proxy != null ? new Socket(proxy) : new Socket();
Review Comment:
@Sineaggi There is no breaking change. The class remains fully API
compatible. Any particular modality or implementation details have never been a
part of the public contract. You abused class inheritance in your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
