[
https://issues.apache.org/jira/browse/HTTPCLIENT-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814826#comment-17814826
]
Michael Osipov edited comment on HTTPCLIENT-2317 at 2/6/24 2:13 PM:
--------------------------------------------------------------------
With:
{noformat}
osipovmi@deblndw011x:~/var/Projekte/httpcomponents-client/httpclient5 (master
*=)
$ git diff -U0
diff --git a/httpclient5/pom.xml b/httpclient5/pom.xml
index 57a5c0c32..bfe2e9cae 100644
--- a/httpclient5/pom.xml
+++ b/httpclient5/pom.xml
@@ -59,0 +60,6 @@
+ <dependency>
+ <groupId>pl.droidsonroids.gradle</groupId>
+ <artifactId>publicsuffix</artifactId>
+ <version>1.0.0</version>
+ <type>pom</type>
+ </dependency>
{noformat}
{{META-INF/DEPENDENCIES}} is properly populated:
{noformat}
// ------------------------------------------------------------------
// Transitive dependencies of this project determined from the
// maven pom organized by organization.
// ------------------------------------------------------------------
Apache HttpClient
From: 'an unknown organization'
- org.brotli:dec (http://brotli.org/dec) org.brotli:dec:jar:0.1.2
License: MIT License (http://www.opensource.org/licenses/mit-license.php)
- org.conscrypt:conscrypt-openjdk-uber (https://conscrypt.org/)
org.conscrypt:conscrypt-openjdk-uber:jar:2.5.2
License: Apache 2 (https://www.apache.org/licenses/LICENSE-2.0)
- Public Suffix List (https://publicsuffix.org/)
pl.droidsonroids.gradle:publicsuffix:pom:1.0.0
License: MPL-2.0 (https://mozilla.org/MPL/2.0/)
From: 'QOS.ch' (http://www.qos.ch)
- SLF4J API Module (http://www.slf4j.org) org.slf4j:slf4j-api:jar:1.7.36
License: MIT License (http://www.opensource.org/licenses/mit-license.php)
From: 'The Apache Software Foundation' (https://www.apache.org/)
- Apache HttpComponents Core HTTP/1.1
(https://hc.apache.org/httpcomponents-core-5.3.x/5.3-alpha1/httpcore5/)
org.apache.httpcomponents.core5:httpcore5:jar:5.3-alpha1
License: Apache License, Version 2.0
(https://www.apache.org/licenses/LICENSE-2.0.txt)
- Apache HttpComponents Core HTTP/2
(https://hc.apache.org/httpcomponents-core-5.3.x/5.3-alpha1/httpcore5-h2/)
org.apache.httpcomponents.core5:httpcore5-h2:jar:5.3-alpha1
License: Apache License, Version 2.0
(https://www.apache.org/licenses/LICENSE-2.0.txt)
{noformat}
[~jlahoda], is that sufficient?
was (Author: michael-o):
With:
{noformat}
osipovmi@deblndw011x:~/var/Projekte/httpcomponents-client/httpclient5 (master
*=)
$ git diff -U0
diff --git a/httpclient5/pom.xml b/httpclient5/pom.xml
index 57a5c0c32..bfe2e9cae 100644
--- a/httpclient5/pom.xml
+++ b/httpclient5/pom.xml
@@ -59,0 +60,6 @@
+ <dependency>
+ <groupId>pl.droidsonroids.gradle</groupId>
+ <artifactId>publicsuffix</artifactId>
+ <version>1.0.0</version>
+ <type>pom</type>
+ </dependency>
{noformat}
{{META-INF/DEPENDENCIES}} is properly populated:
{noformat}
// ------------------------------------------------------------------
// Transitive dependencies of this project determined from the
// maven pom organized by organization.
// ------------------------------------------------------------------
Apache HttpClient
From: 'an unknown organization'
- org.brotli:dec (http://brotli.org/dec) org.brotli:dec:jar:0.1.2
License: MIT License (http://www.opensource.org/licenses/mit-license.php)
- org.conscrypt:conscrypt-openjdk-uber (https://conscrypt.org/)
org.conscrypt:conscrypt-openjdk-uber:jar:2.5.2
License: Apache 2 (https://www.apache.org/licenses/LICENSE-2.0)
- Public Suffix List (https://publicsuffix.org/)
pl.droidsonroids.gradle:publicsuffix:pom:1.0.0
License: MPL-2.0 (https://mozilla.org/MPL/2.0/)
From: 'QOS.ch' (http://www.qos.ch)
- SLF4J API Module (http://www.slf4j.org) org.slf4j:slf4j-api:jar:1.7.36
License: MIT License (http://www.opensource.org/licenses/mit-license.php)
From: 'The Apache Software Foundation' (https://www.apache.org/)
- Apache HttpComponents Core HTTP/1.1
(https://hc.apache.org/httpcomponents-core-5.3.x/5.3-alpha1/httpcore5/)
org.apache.httpcomponents.core5:httpcore5:jar:5.3-alpha1
License: Apache License, Version 2.0
(https://www.apache.org/licenses/LICENSE-2.0.txt)
- Apache HttpComponents Core HTTP/2
(https://hc.apache.org/httpcomponents-core-5.3.x/5.3-alpha1/httpcore5-h2/)
org.apache.httpcomponents.core5:httpcore5-h2:jar:5.3-alpha1
License: Apache License, Version 2.0
(https://www.apache.org/licenses/LICENSE-2.0.txt)
{noformat}
> The license in the httpclient5 artifact on Maven central is not correct.
> ------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2317
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2317
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.5.14, 5.3.1, 5.4-alpha1
> Reporter: Jan Lahoda
> Priority: Minor
>
> Looking at the 'httpclient5' artifact on Maven central, like:
> [https://repo1.maven.org/maven2/org/apache/httpcomponents/client5/httpclient5/5.3.1/httpclient5-5.3.1.jar]
> [https://repo1.maven.org/maven2/org/apache/httpcomponents/client5/httpclient5/5.4-alpha1/httpclient5-5.4-alpha1.jar]
> these contain 'mozilla/public-suffix-list.txt', which is under MPL 2.0, but
> the license file embedded in these artifacts (META-INF/LICENSE) does not
> contain the MPL 2.0.
>
> The binary file downloadable from Apache download server has the correct
> license file:
> [https://dlcdn.apache.org//httpcomponents/httpclient/binary/httpcomponents-client-5.3.1-bin.tar.gz]
>
> It would be nice if the artifacts on Maven central could have the correct
> content of the license file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
