vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528356852
##########
httpclient5/src/test/java/org/apache/hc/client5/http/entity/mime/TestMultipartEntityBuilder.java:
##########
@@ -99,7 +99,7 @@ public void testMultipartContentTypeParameter() throws
Exception {
new BasicNameValuePair("charset", "ascii")))
.buildEntity();
Assertions.assertNotNull(entity);
- Assertions.assertEquals("multipart/form-data; boundary=yada-yada;
charset=US-ASCII", entity.getContentType());
+ Assertions.assertEquals("multipart/form-data; boundary=yada-yada;
charset=ascii", entity.getContentType());
Review Comment:
The charset was explicitly configured via
`ontentType.MULTIPART_FORM_DATA.withParameters(...new
BasicNameValuePair("charset", "ascii")`.
If the user explicitly creates content type with charset, they might know
what they are doing, so there's no point in removing the charset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
